Skip to content

Conversation

@talkor
Copy link
Member

@talkor talkor commented Oct 29, 2025

PR Type

Enhancement, Other


Description

  • Remove testing utilities from shared package

  • Delete interactions-utils module with test helpers

  • Remove test-related dependencies from package.json

  • Keep es-toolkit as primary dependency


Diagram Walkthrough

flowchart LR
  A["interactions-utils.ts<br/>Test helpers"] -->|deleted| B["Removed from exports"]
  C["package.json<br/>Dependencies"] -->|removed| D["@storybook/jest<br/>@storybook/test<br/>@testing-library/react<br/>vitest"]
  E["es-toolkit"] -->|kept| F["Primary dependency"]
Loading

File Walkthrough

Relevant files
Miscellaneous
index.ts
Remove interactions-utils export                                                 

packages/shared/src/tests/index.ts

  • Remove export statement for interactions-utils module
  • Maintain exports for test-utils, test-ids-utils, and constants
+0/-1     
interactions-utils.ts
Delete interactions-utils test utilities file                       

packages/shared/src/tests/interactions-utils.ts

  • Delete entire file containing 261 lines of test interaction utilities
  • Remove helper functions for DOM queries, user interactions, and drag
    operations
  • Remove dependencies on @storybook/test and @testing-library/react
+0/-261 
Dependencies
package.json
Remove test dependencies, keep es-toolkit                               

packages/shared/package.json

  • Remove @vitest/coverage-v8 from devDependencies
  • Remove vitest from devDependencies
  • Remove @storybook/jest, @storybook/test, and @testing-library/react
    from dependencies
  • Keep es-toolkit as the only runtime dependency
  • Move vitest to peerDependencies
+1/-6     

@talkor talkor requested a review from YossiSaadi October 29, 2025 19:51
@talkor talkor marked this pull request as ready for review October 29, 2025 19:53
@talkor talkor requested a review from a team as a code owner October 29, 2025 19:53
@qodo-merge-for-open-source
Copy link
Contributor

qodo-merge-for-open-source bot commented Oct 29, 2025

PR Reviewer Guide 🔍

(Review updated until commit 49bdca6)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
 Summary findings: ⚠️ Title violates Conventional Commits
⚡ Recommended focus areas for review

Broken Export

Removing the interactions-utils export may break consumers that import from @shared/tests. Verify there are no downstream usages or provide a migration note.

export * from "./test-utils";
export * from "./test-ids-utils";
export * from "./constants";
Peer Dependency Choice

Making vitest a peerDependency may force all consumers to install it even if they don’t run tests via this package. Confirm this is intended; alternatively, omit it entirely if unused at runtime.

  "react": ">=16.9.0",
  "vitest": ">=1.6.0"
},

@@ -1,4 +1,3 @@
export * from "./test-utils";
export * from "./test-ids-utils";
export * from "./interactions-utils";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused 🤷🏼‍♂️

Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼 !

@talkor talkor enabled auto-merge (squash) October 30, 2025 08:14
@talkor talkor merged commit 623da2e into master Oct 30, 2025
15 checks passed
@talkor talkor deleted the chore/deps/shared-deps branch October 30, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants