Skip to content

Conversation

@talkor
Copy link
Member

@talkor talkor commented Oct 29, 2025

User description

https://monday.monday.com/boards/3532714909/pulses/18284871707


PR Type

Enhancement


Description

  • Move components folder from root into packages directory

  • Update all path references across configuration and build scripts

  • Adjust relative paths in package.json files and TypeScript configs

  • Update GitHub Actions workflows to reflect new component location


Diagram Walkthrough

flowchart LR
  A["components/ at root"] -->|move| B["packages/components/"]
  B -->|update paths| C["Config files"]
  B -->|update paths| D["Build scripts"]
  B -->|update paths| E["CI/CD workflows"]
  B -->|update paths| F["package.json files"]
Loading

File Walkthrough

Relevant files
Configuration changes
12 files
vitest.config.ts
Update components folder path resolution                                 
+1/-1     
main.ts
Fix Storybook components path and stories glob                     
+1/-2     
compare-bundles.js
Update component name parsing for new structure                   
+2/-2     
generate-size-limit-config.js
Update components path in bundle size config                         
+2/-2     
build-and-upload.yml
Update artifact upload paths for components                           
+2/-1     
bundle-size.yml
Update workflow trigger paths for components                         
+1/-1     
package.json
Update workspace configuration for components                       
+1/-1     
package.json
Fix eslint config relative path depth                                       
+1/-1     
package.json
Fix eslint config relative path depth                                       
+1/-1     
package.json
Fix eslint config relative path depth                                       
+1/-1     
vitest.config.mjs
Update vitest component aliases path                                         
+1/-1     
tsconfig.storybook.json
Update TypeScript path mappings for components                     
+2/-2     
Additional files
45 files
CHANGELOG.md [link]   
rollup.config.mjs [link]   
Button.module.scss [link]   
Button.tsx [link]   
Button.types.ts [link]   
ButtonConstants.ts [link]   
Button.snapshot.test.tsx [link]   
Button.test.jsx [link]   
dom-helpers.ts [link]   
useButtonLoading.ts [link]   
index.ts [link]   
index.ts [link]   
files.d.ts [link]   
tsconfig.json [link]   
vitest.config.mjs [link]   
vitest.setup.mjs [link]   
CHANGELOG.md [link]   
rollup.config.mjs [link]   
CustomSvgIcon.tsx [link]   
FontIcon.tsx [link]   
Icon.module.scss [link]   
Icon.tsx [link]   
allIcons.test.ts [link]   
constants.ts [link]   
useIconProps.tsx [link]   
useIconScreenReaderAccessProps.ts [link]   
index.ts [link]   
types.ts [link]   
index.ts [link]   
files.d.ts [link]   
tsconfig.json [link]   
CHANGELOG.md [link]   
rollup.config.mjs [link]   
Loader.module.scss [link]   
Loader.tsx [link]   
Loader.types.ts [link]   
LoaderConstants.ts [link]   
Loader.snapshot.test.tsx [link]   
Loader.test.jsx [link]   
index.ts [link]   
index.ts [link]   
files.d.ts [link]   
tsconfig.json [link]   
vitest.config.mjs [link]   
vitest.setup.mjs [link]   

@qodo-merge-for-open-source
Copy link
Contributor

qodo-merge-for-open-source bot commented Oct 29, 2025

PR Reviewer Guide 🔍

(Review updated until commit b3c8d90)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Path Mapping

The new "@vibe/" and include paths appear inconsistent with the repo move. Verify that the include/glob paths actually point to "packages/components//src" and not the old location to prevent Storybook/TS resolution issues.

    "@vibe/core/interactionsTests": ["../core/src/tests/interactions-utils.ts"],
    "@vibe/core": ["../core/src/index.ts"],
    "@vibe/shared": ["../shared/src/index.ts"],
    "@vibe/*": ["../components/*/src", "../*/src"]
  }
},
"include": ["src/**/*", "types/**/*", "scripts/**/*.ts", ".storybook/**/*", "../../components/*/src/**/*"]
Components Path

The new componentsFolder is set via __dirname two levels up; confirm Storybook runs from this file's directory so the calculated path resolves to "packages/components" across environments (local/CI).

const componentsFolder = path.resolve(__dirname, "../../components");
const components = fs.readdirSync(componentsFolder).reduce((acc: Record<string, string>, component) => {
Display Name Logic

The new prefix check uses "packages/components/"; ensure upstream producers of componentName use the same prefix on all platforms, or normalize paths to avoid mismatches.

if (componentName.startsWith("packages/components/")) {
  const packageName = componentName.split("/")[2];
  displayName = `@vibe/${packageName}`;
} else {

@talkor talkor merged commit 231307f into master Nov 4, 2025
16 of 17 checks passed
@talkor talkor deleted the chore/components-move branch November 4, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants