Skip to content

Conversation

@talkor
Copy link
Member

@talkor talkor commented Nov 3, 2025

PR Type

Documentation


Description

  • Update Storybook deployment folder path from packages/core/static_storybook to packages/docs/static_storybook

  • Corrects GitHub Pages deployment action to reference correct documentation build output location


Diagram Walkthrough

flowchart LR
  A["publish-storybook.yml"] -- "updates folder path" --> B["packages/docs/static_storybook"]
  C["Old path: packages/core/static_storybook"] -.->|replaced| B
Loading

File Walkthrough

Relevant files
Configuration changes
publish-storybook.yml
Update Storybook deployment folder path                                   

.github/workflows/publish-storybook.yml

  • Changed Storybook deployment folder path from
    packages/core/static_storybook to packages/docs/static_storybook
  • Ensures GitHub Pages deployment action deploys from the correct
    documentation build directory
+1/-1     

@talkor talkor requested a review from a team as a code owner November 3, 2025 11:53
@qodo-merge-for-open-source
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Path Validity

Verify that the Storybook build actually outputs to packages/docs/static_storybook in CI and that the build step runs before this deploy action.

- name: Push core Storybook to Github Pages
  uses: JamesIves/[email protected]
  with:
    clean-exclude: |
      v2/*
      playground/*
    folder: packages/docs/static_storybook
    branch: gh-pages

@talkor talkor merged commit af6a8e6 into master Nov 3, 2025
15 checks passed
@talkor talkor deleted the docs/fix-publish branch November 3, 2025 12:08
@qodo-merge-for-open-source
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No auditing: The change only updates a deployment folder path and does not implement or modify any
audit logging for critical actions, making it impossible to confirm compliance from this
diff alone.

Referred Code
folder: packages/docs/static_storybook
branch: gh-pages
Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No error handling: The workflow step configuration only changes the deploy folder and does not show any error
handling or retries, so robustness cannot be verified from this diff alone.

Referred Code
  folder: packages/docs/static_storybook
  branch: gh-pages
env:
Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status:
Error exposure unclear: The change does not affect or show user-facing error messages or logging behavior, so it
is unclear whether secure error handling is ensured in this workflow.

Referred Code
- name: Push core Storybook to Github Pages
  uses: JamesIves/[email protected]
  with:
    clean-exclude: |
      v2/*
      playground/*
    folder: packages/docs/static_storybook
    branch: gh-pages
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
Input validation N/A: The modification only changes a deployment folder path in a CI workflow and does not
expose input handling or data processing, so security validation cannot be assessed from
this diff alone.

Referred Code
folder: packages/docs/static_storybook
branch: gh-pages
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants