Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set names of commands #70

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Set names of commands #70

merged 1 commit into from
Jun 12, 2024

Conversation

M-arcus
Copy link
Contributor

@M-arcus M-arcus commented May 27, 2024

Description

[WARNING] Some commands could not be registered:

In Application.php line 535:
                                                                                                        
  [Symfony\Component\Console\Exception\LogicException]                                                  
  The command defined in "Mondu\MonduPayment\Command\ConfigApiTokenCommand" cannot have an empty name.  

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings
  • I have added tests that prove my fix is effective or that my feature works

@hreinberger
Copy link

@M-arcus thx for your contribution!

@mondu-ai/purchase can you take a look here pls?

@ume3119
Copy link
Member

ume3119 commented May 29, 2024

@M-arcus thx for your contribution!

@mondu-ai/purchase can you take a look here pls?

@tikohov20 please review.

@tikohov20 tikohov20 self-requested a review June 6, 2024 07:33
@tikohov20
Copy link
Member

@M-arcus thank you for contributing, the changes will be included in the upcoming release.

@tikohov20 tikohov20 merged commit 3cfa68d into mondu-ai:main Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants