Dutch translation of website-sections and storyboard

[Josketobben]

No description provided.

[lh1008]

Hi @erciccione,

This is meant to add the refuge.md 'nl' file. I see there are a lot of commits, is this normal?

[lh1008]

From the technical level, everything looks good, reviewed .md format and links. Only a language review would be missing.

[erciccione]

This is meant to add the refuge.md 'nl' file. I see there are a lot of commits, is this normal?

Yes, he probably did the translation in many stages and commit every time. Not a problem, i can squash when merging.

Waiting for a review of the content.

[lh1008]

Ok, thank you for the clarification.

[Josketobben]

I committed in one go, I don't know why it's showing commit messages from the previous job. It's the first time I pushed from the command line, maybe it has something to do with that?

[erciccione]

@Josketobben Now i see there are some merge commits, i guess something went wrong while committing locally. Best would be for you to recommit the file using an updated branch, but it's not a big deal, as i said, i can squash while merging.

[erciccione]

@Josketobben I see you added a commit which add changes to another file. Please change the title accorgingly. next time would be better to open a different PR, since this one has already all commits messed up and adding a non-related one only make things more unclear.

Please contact me if you need help and suggestions on how git's workflow works.

[Josketobben]

There shouldn't be any changes to any other files. These are the changes from the previous job, as I said. I reckon I messed up syncing the local branch on my machine, or am just failing to commit single files somehow.

[erciccione]

@Josketobben commit a58fa5c was added right before my last comment and it's editing another file: wallet_quickstart_nl.md. you can see 2 files got changed in this PR: refuge_en.md and wallet_quickstart_nl.md. Do you mean that you only worked on one file and the changes to the second one are a mistake? if yes, which one is the file you are working on? If you worked on both files please change the title ofthe PR so that we can keep track of the changes.

[Josketobben]

@erciccione I see, git automatically combines pull requests. Yes then it's become two files in total, in the meanwhile. But so no edits, just to be clear. I've updated the title.

[erciccione]

Yes, to open different pull requests the commits should be added on different branches, or git won't be able to see the difference. Thanks for clarifying.

Waiting for reviewers.

[lh1008]

@Josketobben are you around?