Add More Fiat Currencies #3852

elibroftw · 2022-03-07T21:32:10Z

@selsta , this just needs to be tested and then the tickers from #3362, can be added

selsta · 2022-03-07T22:26:00Z

Could you remove the unrelated whitespace changes? Makes it easier to review.

elibroftw · 2022-03-07T22:44:48Z

You can hide whitespace changes.
https://github.com/monero-project/monero-gui/pull/3852/files?diff=split&w=1

selsta · 2022-03-08T03:56:16Z

You can hide whitespace changes.

It pollutes git blame with unnecessary changes so usually we try to avoid whitespace changes but it's not that important here.

elibroftw · 2022-03-08T04:18:33Z

Don't merge this yet btw. Will need to test on local machine.

selsta · 2022-03-08T04:19:44Z

I did some basic testing but more testing is always good.

elibroftw · 2022-03-08T04:23:10Z

The dropdown worked fine? That was my only concern.

selsta · 2022-03-08T04:25:08Z

yes, but I'll try to add a third currency

elibroftw · 2022-03-08T04:26:44Z

Do you know if the Windows builds will be fixed soon? Or is it only failing on CI?

selsta · 2022-03-08T04:28:15Z

I have asked luigi to merge #3849

selsta · 2022-03-08T04:33:07Z

@elibroftw if you force push now Windows should be green

elibroftw · 2022-03-08T04:50:02Z

You know if there's any future plans to support Visual Studio through vcpkg instead of requiring msys? Probably not right?

selsta · 2022-03-08T04:51:08Z

It's a cross platform application and I don't know if Qt supports Visual Studio, so likely no. At least I won't add support for it as I'm not a Windows user.

elibroftw · 2022-03-08T05:07:54Z

I don't think the Windows build instructions are correct. I'm getting

maste@DESKTOP-F8TRQIV MINGW64 ~/monero-gui
$ cmake release-win64 -j4
bash: cmake: command not found

maste@DESKTOP-F8TRQIV MINGW64 ~/monero-gui
$ cmake release-win64 -j4
bash: cmake: command not found

maste@DESKTOP-F8TRQIV MINGW64 ~/monero-gui
$ ^C

maste@DESKTOP-F8TRQIV MINGW64 ~/monero-gui
$

After installing the libraries

selsta · 2022-03-08T05:09:08Z

They say make release-win64 -j4 not cmake release-win64 -j4

elibroftw · 2022-03-08T05:10:47Z

I tried both, the former didn't work so I tried cmake. make was not found either.

selsta · 2022-03-08T05:11:38Z

what is the output? also did you start the correct mingw64 console?

elibroftw · 2022-03-08T05:14:32Z

Yeah I started

Anyways, just merge whenever you feel like it since it worked it in the first place. Then I can create a PR for adding more currencies. I'll just test that one my laptop which I dual boot with Linux.

elibroftw · 2022-03-08T20:05:52Z

Tested this on my laptop, it works!

elibroftw · 2022-03-12T15:40:09Z

Can this get merged? Or should I add the fiat currencies in this PR itself?

elibroftw · 2022-03-15T02:05:41Z

Helloooooooooooooooooooooooooooooooooo?

selsta · 2022-03-15T02:07:23Z

Didn't have time to go through all emails yet.

To answer your question, however you want. You can wait for it to get merged or add extra currencies here too, ideally in a separate commit.

elibroftw · 2022-03-15T17:59:51Z

The currencies work for coingecko and cryptocompare, but the kraken API is not getting called and kraken doesn't support XMR pairs other than with USD and EUR as far as I can tell

elibroftw · 2022-03-15T18:11:01Z

And also the most important part is that the dropdown is not scrollable:

selsta · 2022-03-27T16:26:32Z

Click on summary and then scroll down.

elibroftw · 2022-03-27T16:59:27Z

maste@Zealth:~/Downloads/docker-linux-static$./monero-wallet-gui
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: xcb, xcb, minimal, offscreen, vnc.

Aborted (core dumped)

I guess this is why I can't run the stable build as well I installed from the store?

selsta · 2022-03-27T20:18:32Z

I'm unfamiliar with wayland.

reemuru · 2022-03-27T20:21:16Z

Ugh, I remember when Fedora first changed to wayland it was kinda buggy so I stayed on x11 as long as I could, but now it works fine. There are some apps which still misbehave though. @elibroftw are you able to run x11 desktop?

elibroftw · 2022-03-27T20:50:23Z

I know I can switch to X11, but I don't know why it still thinks I'm on wayland.


maste@Zealth:~/Downloads/docker-linux-static$ ./monero-wallet-gui 
qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: xcb, xcb, minimal, offscreen, vnc.

Aborted (core dumped)
maste@Zealth:~/Downloads/docker-linux-static$ head /etc/gdm3/custom.conf
# GDM configuration storage
#
# See /usr/share/gdm/gdm.schemas for a list of available options.

[daemon]
# Uncomment the line below to force the login screen to use Xorg
WaylandEnable=false

# Enabling automatic login
#  AutomaticLoginEnable = true
maste@Zealth:~/Downloads/docker-linux-static$

elibroftw · 2022-03-27T21:14:16Z

It seems I can't run even the self compiled version anymore.

WizardCornelius · 2022-12-03T11:30:50Z

Hey guys, can I enquire whether this feature is still being worked on? It'd be amazing to use the wallet showing GBP fiat amount. Thanks for your time.

elibroftw · 2022-12-03T15:46:07Z

I will try to work on it today. I stopped because I couldn't run the GUI anymore on my Linux machine but I installed a different distro recently plus I might be able to develop on windows itself.

WizardCornelius · 2022-12-04T09:56:56Z

Thanks mate, I really appreciate your time! I'm disabled, and the extra currency conversions I have to do using monero really exhaust me. It means a lot. Lmk if I can donate to support your work on this feature in some way.

elibroftw · 2023-01-06T20:16:10Z

Okay so I was able to take a look today and debugged some stuff. The issue is caused by the fact that the dropdown is a nested layout and combined with dynamically populating the fiat currencies listmodel. I honestly don't like that a ListModel is used when an array would suffice but maybe that's how QML works . We can either hard code the fiat currencies as ListElement and avoid the warning or rework the DropDown first. I suggest reworking the dropdown first as reemeru already has one started #3868 to fix the scrollable which isn't 100% usable.

elibroftw · 2023-01-06T20:34:34Z

@WizardCornelius , for now I think you should use FeatherWallet. It's not the most optimal in terms of its layout, but it supports fiat pricing out of the box.

main.qml

selsta · 2023-01-08T02:33:38Z

Please remove the .vscode changes since they are unrelated to this PR.

elibroftw · 2023-04-29T23:21:52Z

Done but I hope the vscode settings PR gets approved as it will improve productivity

plowsof · 2023-04-30T10:09:05Z

pages/settings/SettingsLayout.qml

                fiatPriceProviderDropDown.currentIndex = i;
            i += 1;
        }

        console.log('SettingsLayout loaded');
    }
 }
-


revert all the unnecessary white space changes to reduce the diffs of this PR please

Just let it be.

Killercat103 · 2023-09-13T20:55:09Z

Any plans to potentially merge this?

elibroftw · 2023-11-13T16:31:18Z

@Killercat103 I'll probably end up creating a desktop wallet app myself before this PR gets merged. Reviewers are a bit too staunch when it comes to my PRs (3 in total).

main.qml

Killercat103 · 2023-11-21T14:24:22Z

Apparently the main issue is that the dropdown menu gets buggy when containing many currencies.

elibroftw force-pushed the master branch from 7467c22 to ae53710 Compare March 7, 2022 21:42

selsta approved these changes Mar 8, 2022

View reviewed changes

elibroftw force-pushed the master branch from 51be1ff to 562162f Compare March 8, 2022 04:54

elibroftw force-pushed the master branch 4 times, most recently from 2f380f8 to a852d7c Compare March 15, 2022 13:21

elibroftw marked this pull request as draft April 24, 2022 22:12

elibroftw force-pushed the master branch from 6a5f3fb to 5fe2db8 Compare December 3, 2022 22:39

elibroftw force-pushed the master branch from a45a002 to ab01c78 Compare January 6, 2023 20:09

plowsof reviewed Jan 6, 2023

View reviewed changes

main.qml Show resolved Hide resolved

elibroftw force-pushed the master branch 2 times, most recently from 33858a3 to 4cbed50 Compare January 6, 2023 23:09

elibroftw marked this pull request as ready for review January 6, 2023 23:27

elibroftw force-pushed the master branch 2 times, most recently from 8de5f3d to bb8cecb Compare January 7, 2023 18:55

elibroftw force-pushed the master branch from bb8cecb to b397e42 Compare April 29, 2023 23:21

plowsof reviewed Apr 30, 2023

View reviewed changes

selsta reviewed Nov 21, 2023

View reviewed changes

main.qml Outdated Show resolved Hide resolved

Add more fiat currencies

c090f6c

elibroftw force-pushed the master branch from b397e42 to c090f6c Compare November 22, 2023 05:43

Add More Fiat Currencies #3852

Are you sure you want to change the base?

Add More Fiat Currencies #3852

Conversation

elibroftw commented Mar 7, 2022

selsta commented Mar 7, 2022 • edited Loading

elibroftw commented Mar 7, 2022 • edited Loading

selsta commented Mar 8, 2022

elibroftw commented Mar 8, 2022 • edited Loading

selsta commented Mar 8, 2022

elibroftw commented Mar 8, 2022

selsta commented Mar 8, 2022

elibroftw commented Mar 8, 2022

selsta commented Mar 8, 2022

selsta commented Mar 8, 2022

elibroftw commented Mar 8, 2022

selsta commented Mar 8, 2022

elibroftw commented Mar 8, 2022 • edited Loading

selsta commented Mar 8, 2022

elibroftw commented Mar 8, 2022 • edited Loading

selsta commented Mar 8, 2022

elibroftw commented Mar 8, 2022 • edited Loading

elibroftw commented Mar 8, 2022

elibroftw commented Mar 12, 2022

elibroftw commented Mar 15, 2022

selsta commented Mar 15, 2022

elibroftw commented Mar 15, 2022 • edited Loading

elibroftw commented Mar 15, 2022

selsta commented Mar 27, 2022

elibroftw commented Mar 27, 2022 • edited Loading

selsta commented Mar 27, 2022

reemuru commented Mar 27, 2022 • edited Loading

elibroftw commented Mar 27, 2022 • edited Loading

elibroftw commented Mar 27, 2022

WizardCornelius commented Dec 3, 2022

elibroftw commented Dec 3, 2022

WizardCornelius commented Dec 4, 2022

elibroftw commented Jan 6, 2023 • edited Loading

elibroftw commented Jan 6, 2023

selsta commented Jan 8, 2023

elibroftw commented Apr 29, 2023

plowsof Apr 30, 2023

Choose a reason for hiding this comment

elibroftw Apr 30, 2023

Choose a reason for hiding this comment

Killercat103 commented Sep 13, 2023

elibroftw commented Nov 13, 2023 • edited Loading

Killercat103 commented Nov 21, 2023

selsta commented Mar 7, 2022 •

edited

Loading

elibroftw commented Mar 7, 2022 •

edited

Loading

elibroftw commented Mar 8, 2022 •

edited

Loading

elibroftw commented Mar 8, 2022 •

edited

Loading

elibroftw commented Mar 8, 2022 •

edited

Loading

elibroftw commented Mar 8, 2022 •

edited

Loading

elibroftw commented Mar 15, 2022 •

edited

Loading

elibroftw commented Mar 27, 2022 •

edited

Loading

reemuru commented Mar 27, 2022 •

edited

Loading

elibroftw commented Mar 27, 2022 •

edited

Loading

elibroftw commented Jan 6, 2023 •

edited

Loading

elibroftw commented Nov 13, 2023 •

edited

Loading