flatpak: Add workflow

[BigmenPixel0]

A new release will trigger the workflow. It builds the flatpak package in 3 parts (because of slow QEMU), prints hashes and pushes to Flathub via the secret token.

[selsta]

Have you thought about using upload-artifact / download-artifact instead of the cache to pass data between the jobs?

https://github.com/actions/upload-artifact
https://github.com/actions/download-artifact

At the end you can also use

https://github.com/marketplace/actions/delete-artifact

to delete the temporary data. My worry with using a cache is that other jobs might delete data in between the steps due to the 10GB limit.

https://github.com/monero-project/monero-gui/actions/caches

[BigmenPixel0]

Have you thought about using upload-artifact / download-artifact instead of the cache to pass data between the jobs?

Oh, that would be much better!

[BigmenPixel0]

There is a problem with uploading an artifact.
This is the bug.

[selsta]

What if you .tar the dir manually before uploading the .tar?

https://github.com/actions/upload-artifact#maintaining-file-permissions-and-case-sensitive-files

[selsta]

tar -cvf flatpak-builder.tar .flatpak-builder

...

    - name: Save flatpak-builder
      uses: actions/upload-artifact@v3
      with:
        name: flatpak-builder-${{ matrix.arch }}
        path: flatpak-builder.tar

    - name: Restore flatpak-builder
      uses: actions/download-artifact@v3
      with:
        name: flatpak-builder-${{ matrix.arch }}
        path: flatpak-builder.tar

...

tar -xvf flatpak-builder.tar

[BigmenPixel0]

x86_64 flatpak-builder.tar was uploaded succesfully, so now I'm waiting for X hours. :)

[selsta]

It seems alternatively you could also manually delete the socket file: https://github.com/input-output-hk/cardano-node/pull/2012/files

[selsta]

Does this have to be changed in advanced? Sometimes we don't know the exact release date.

[BigmenPixel0]

Does this have to be changed in advanced?

Yes.

Sometimes we don't know the exact release date.

Even, for example, the day before the release or the day? I could create a PR that will be accepted before release, or the problem still is not solved so?

[BigmenPixel0]

In OBS it's done interesting.

[selsta]

So this can be changed after the release tag is set? Or can it be automatically set by a script before the workflow is running?

I'll think about it more.

Also seems OBS doesn't have any historical releases. Are they necessary?

[BigmenPixel0]

So this can be changed after the release tag is set? Or can it be automatically set by a script before the workflow is running?

It will be need to add some CMake files, so it won't be need to change the appdata file every release.

Also seems OBS doesn't have any historical releases. Are they necessary?

Desirable, but not required.

[BigmenPixel0]

For now there are 2 problems: metainfo updating and CI checks before flatpak building (or wait for a new release of flat-manager or make it manually).

[selsta]

CI checks before flatpak building (or wait for a new release of flat-manager or make it manually).

Can you expand on this? I would like to wait with the build process until a new release is set here: https://github.com/monero-project/monero-gui/releases

We don't want that every tag gets pushed since sometimes we have tags that are buggy or miss something.

[BigmenPixel0]

CI checks before flatpak building (or wait for a new release of flat-manager or make it manually).

Can you expand on this?

These are appdata and manifest checkers.

[BigmenPixel0]

It will push to the beta branch because we should test the beta token.

[BigmenPixel0]

I changed the token FLATHUB_TOKEN_BETA to FLATHUB_ because exactly FLATHUB_ has been added to the secrets. :)
That's only beta token which will be changed to the stable.

[selsta]

Is this documented somewhere? I don't see push here, but maybe I'm looking at the wrong place or missing something.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release

[BigmenPixel0]

Ah, you're right. That's a beta token which pushes to the beta repo. I wanted it to push every commit (temporary).

on:
  push

Is it correct?

[BigmenPixel0]

Now resolved?

[selsta]

Yes, but this will need planning. I don't want to run a multi-hour long CI on each commit after this is merged. So this has to be merged, then one test commit is run and then reverted.

[BigmenPixel0]

OK, so is it better to push before other prs now or at the final after (to not create a lot of workflows)?

[selsta]

Probably best to merge this last.

[adrelanos]

flathub has a verified blue checkmark similar to Twitter. It shows that a flathub project is official and not by random third-party. Please consider applying for it.

• Verify Monero on flathub #4206

[selsta]

I think this can be tested now.