Skip to content

Win deploy: Boost Regex is header-only since 1.77 #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Malinero
Copy link
Contributor

@selsta
Copy link
Collaborator

selsta commented Feb 19, 2025

While the patch itself looks good, why is this needed? Is deploy currently broken?

1.77 came out a while ago.

@Malinero
Copy link
Contributor Author

I think it's currently broken. I don't have a windows, but while trying to debug the windows CI on #4407, I saw this https://github.com/Malinero/monero-gui/actions/runs/13379636601/job/37365795118#step:4:761

Result of :

        foreach(ITEM ${WIN_DEPLOY_DLLS})
            find_file(${ITEM}_VAR ${ITEM} REQUIRED)
        endforeach()

Copy link
Collaborator

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this only broke now.

@tobtoht
Copy link
Collaborator

tobtoht commented Feb 20, 2025

Not sure why this only broke now.

MSYS2 used to ship a static compatibility library and stopped doing that a few months ago.

@tobtoht tobtoht merged commit daf3a1c into monero-project:master Feb 24, 2025
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants