checkpoints: allow for testnet and stagenet #10117
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: nahuhh <[email protected]>
…enet this is to allow private test/stagenets to exist without conflicting with hardcoded values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doesnt make sense to me that these would be hard disabled.
the only issue would be for private testnets or private stagenets that conflict with the hardcoded checkpoints above block 1000000 and 10000, respectively. Perhaps we should remove the hardcoded stagenet/testnet checkpoint values? Before this pr, they hardcoded checkpoints werent used/usable at all ..
edit: added second commit to disable the hardcoded checkpoint values for test and stage
Note: this doesnt enable precomputed hashes (to allow fast-block-sync) as was done here for the previous stressnet