crypto: break out fe_pow22523 into separate function #10134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in sqrt implemented in FCMP++, which is used in this
torsion_check_vartime.torsion_check_vartimeis part of an optimization* that wallets use to check outputs and commitments for torsion, before clearing torsion if they do indeed have torsion (most are expected to not have torsion, hence this optimization). Outputs in the tree cannot have torsion. Wallets build the tree locally, and therefore need to make sure torsioned outputs do not enter the tree.*
torsion_check_vartimeis currently unproven. That is why the integration presently only uses it wallet-side in order to speed up wallet sync, and not at consensus. Wallet-side worst case is a DoS. Daemon-side worst case is inflation. Theoretically we could hold off on using it wallet-side until after the fork, at which point we ban torsioned outputs at consensus, and can therefore be certain the function works correctly for all pre-fork potentially torsioned outputs.