Daemon RPC: /getblocks.bin optional block_ids_exclusive req param #10143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
j-berman
force-pushed
the
daemon-skip-common-block
branch
from
0ee2c16 to
ba0cfe4
Compare
j-berman
changed the title
Collaborator
Author
Updated to use |
iamamyth
reviewed
Oct 7, 2025
src/cryptonote_core/blockchain.cpp
Outdated
| db_rtxn_guard rtxn_guard(m_db); | ||
| top_hash = m_db->top_block_hash(&total_height); | ||
| ++total_height; | ||
| CHECK_AND_ASSERT_MES(total_height >= start_height, false, "chain height expected to be higher than start block"); |
There was a problem hiding this comment.
Minor issue, but the message here doesn't match the assertion (ignores equality); suggest something like: Start height cannot exceed chain height.
Collaborator
Author
There was a problem hiding this comment.
Actually it should really be total_height > start_height, good spot
Collaborator
Author
There was a problem hiding this comment.
Fixed to check total_height > start_height
iamamyth
approved these changes
Oct 7, 2025
iamamyth
left a comment
iamamyth
left a comment
There was a problem hiding this comment.
Looks OK, apart from the (easily resolved) inaccuracy of the assertion message.
When the request includes block_ids, the daemon uses find_blockchain_supplement to identify the highest block hash passed in block_ids that the daemon also knows about, and then serves subsequent blocks contiguous to that block. When block_ids_skip_exclusive is false (default current behavior), the daemon includes the highest block requested in the response, in addition to contiguous blocks after it. When block_ids_skip_exclusive is true (new param), the daemon serves blocks starting from the block 1 higher than the highest known block included in block_ids. Thus, the daemon skips the common block known to the client and daemon. Clients can make sure the daemon is serving expected contiguous blocks to its highest known block by checking the first block's prev_id included in the response, and making sure it is equivalent to the block the client already knows about that was included in block_ids. This avoids the daemon serving 1 extra block it does not need to serve to the client, since the client should already know about that block. bl
j-berman
force-pushed
the
daemon-skip-common-block
branch
from
ba0cfe4 to
4a2d6eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the request includes
block_ids, the daemon usesfind_blockchain_supplementto identify the highest block hash passed inblock_idsthat the daemon also knows about, and then serves subsequent blocks contiguous to that block.When
block_ids_exclusiveis false (default current behavior), the daemon includes the highest block requested in the response, in addition to contiguous blocks after it.When
block_ids_exclusiveis true (new param), the daemon serves blocks starting from the block 1 higher than the highest known block included inblock_ids. Thus, the daemon skips the common block known to the client and daemon. Clients can make sure the daemon is serving expected contiguous blocks to its highest known block by checking the first block'sprev_idincluded in the response, and making sure it is equivalent to the block the client already knows about that was included inblock_ids. This avoids the daemon serving 1 extra block it does not need to serve to the client, since the client should already know about that block.This optimization is used in the FCMP++ integration wallet2 refresh, implemented as part of this PR refactoring wallet2 refresh: seraphis-migration#81