BlockchainDB: rm skip_coinbase in get_blocks_from()
#10166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameter `skip_coinbase` was always set to `true`, and didn't actually skip the coinbase transactions. The method broke when set to `false`. Noticed by @akildemir
iamamyth
reviewed
Oct 14, 2025
|
|
||
| current_block.second.reserve(b.tx_hashes.size()); | ||
| num_txes += b.tx_hashes.size() + (skip_coinbase ? 0 : 1); | ||
| num_txes += b.tx_hashes.size() + 1; |
There was a problem hiding this comment.
If skip_coinbase was previously true, adding 1 here would change the behavior.
Contributor
Author
There was a problem hiding this comment.
This simply makes the num_txes count more accurate, which makes the limiting check against max_tx_count more accurate as well.
Contributor
Author
There was a problem hiding this comment.
@iamamyth Can you please revisit this review?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter
skip_coinbasewas always set totrue, and didn't actually skip the coinbase transactions. The method broke when set tofalse.Noticed by @akildemir.