epee: align container pod as blob serialization #10170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`{un}serialize_stl_container_pod_val_as_blob()` use aligned memory accesses on potentially unaligned pointers.
jeffro256
force-pushed
the
align_pod_container_blob
branch
from
356ae51 to
ece0342
Compare
Contributor
Author
|
There's potential issues if the |
vtnerd
approved these changes
Oct 15, 2025
vtnerd
reviewed
Oct 15, 2025
| hint_resize(container, count); | ||
| for(size_t i = 0; i < count; i++) | ||
| container.insert(container.end(), *(pelem++)); | ||
| { |
Contributor
There was a problem hiding this comment.
The existing code was using the copy constructor, and not assignment operator .. ?
Contributor
Author
There was a problem hiding this comment.
Yeah, sorry, I meant both of them. It uses assignment on the serialization side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{un}serialize_stl_container_pod_val_as_blob()use aligned memory accesses on potentially unaligned pointers.