Fix --anonymous-inbound data leak [0.18] #9633
Open
+23
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
force-pushed
the
fix/anonymous_inbound_0.18
branch
from
9221a8d to
2b1e383
Compare
|
See other PR for force push explanation. |
vtnerd
changed the title
|
@selsta something wrong with the 0.18 branch right now? These errors look unrelated. |
|
@vtnerd you updated the trezor submodule |
|
Yup, I see it now, thanks. |
selsta
reviewed
Dec 20, 2024
| @@ -2483,26 +2484,38 @@ namespace nodetool | |||
| std::vector<peerlist_entry> local_peerlist_new; | |||
| zone.m_peerlist.get_peerlist_head(local_peerlist_new, true, max_peerlist_size); | |||
|
|
|||
| /* Tor/I2P nodes receiving connections via forwarding (from tor/i2p daemon) | |||
| do not know the address of the connecting peer. This is relayed to them, | |||
| iff the node has setup an inbound hidden service. The other peer will have | |||
There was a problem hiding this comment.
I don't see the typo, can you elaborate?
There was a problem hiding this comment.
I thought iff is supposed to be if but seems it's an abbreviation I wasn't aware of.
vtnerd
force-pushed
the
fix/anonymous_inbound_0.18
branch
from
2b1e383 to
53ffc8d
Compare
|
The last force push should fix the external submodule that was bad. |
0xFFFC0000
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #9632 but on release branch.