Skip to content

wallet: immediate lookahead table expansion + set_subaddresss_lookahead RPC endpoint [0.18] #9954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release-v0.18
Choose a base branch
from

Conversation

nahuhh
Copy link
Contributor

@nahuhh nahuhh commented Jun 12, 2025

release version of #9953 / #8981

@nahuhh
Copy link
Contributor Author

nahuhh commented Jun 13, 2025

I've tested wallet-cli's set subaddress-lookahead and it works as expected.

things to note:

  • this does not work retroactively. If you missed any transactions, you'll have to scan_tx for them
  • wallet-rpc is not persistent. I'm not sure how this behaves in practice. Example: change lookahead from default 200 to 500 -> receive tx on minor index 500 -> lookahead is now to index 1000 -> restart wallet = does the wallet forget about subaddress 701-1000? Or does it just not expand until it reaches 800 now?

future:

  • wallet-rpc should be made persistent, perhaps in a follow-up pr.
  • perhaps subaddress-lookahead should rollback the wallet height to the last known transaction, so missed transactions are found automatically

@plowsof
Copy link
Contributor

plowsof commented Jun 14, 2025

wallet-rpc is not persistent.

Currently wallet rpc cache has to be saved manually with store, i dont know of anything which triggers store off the top of my head. *ctrl+c? 😄

@plowsof
Copy link
Contributor

plowsof commented Jun 17, 2025

i've went down a rabbit hole sanity checking the effects of changing set subaddress-lookahead without this patch, these instructions will help us to test this PR #7364 (comment)

@nahuhh nahuhh force-pushed the pr/8981_release branch from 9036c71 to bebef64 Compare July 3, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants