Added Beldex Coin #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when adding a new coin
…could just make plain value in the QR assuming all is wanted is data transfer, but regardless this work better than no QA at all for non-Monero coins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added some good code improvements, QR fixed for other coins, adding new cryptonote based coins is easier now. Cleaned faulty "restore prev coin" logic with new one, a case when someone hit cancel after coin change.
Also fixed a bug for missing url query added by someone else.
This branch is "pure" to your repo. Technically in my master fork I rebranded everything, so you may first looks at mine master just to see what I mean. The
beldexbranch is made directly of yourmasterand I placedbeldexas 2nd coin in the dropdown, the rest (besides fixes and refactoring) is not changed.If you decide to use my PR, please make a merge to preserve my commits and some misc credits.