feat(data-modeling): add side panel COMPASS-9476 #7111
+131
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a side panel to the diagram editor that opens when an edge is clicked.
- Introduce Redux state (
side-panel.ts) for tracking panel open/closed - Wire
openSidePanelaction intoDiagramEditorand displayDiagramEditorSidePanel - Integrate new component into the main
DataModelingview
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/compass-data-modeling/src/store/side-panel.ts | New Redux module for side‐panel state, actions, and reducer |
| packages/compass-data-modeling/src/store/reducer.ts | Combined sidePanel slice into root reducer and action types |
| packages/compass-data-modeling/src/components/diagram-editor.tsx | Added onEdgeClick handler dispatching openSidePanel |
| packages/compass-data-modeling/src/components/diagram-editor-side-panel.tsx | New side‐panel component connected to Redux |
| packages/compass-data-modeling/src/components/data-modeling.tsx | Render DiagramEditorSidePanel alongside DiagramEditor |
Comments suppressed due to low confidence (2)
packages/compass-data-modeling/src/components/diagram-editor-side-panel.tsx:36
- Typo in component name:
DiagmramEditorSidePanelshould beDiagramEditorSidePanelto match the file name and naming conventions.
function DiagmramEditorSidePanel({
packages/compass-data-modeling/src/store/side-panel.ts:27
- No unit tests were added for
sidePanelReducer. Consider adding tests to verify that the open and close actions correctly updateisOpenstate.
export const sidePanelReducer: Reducer<SidePanelState> = (
| return null; | ||
| } | ||
| return ( | ||
| <div className={cx(containerStyles, isDarkMode && darkModeContainerStyles)}> |
There was a problem hiding this comment.
Consider adding appropriate ARIA attributes (e.g., role="dialog", aria-label) to the panel container so screen readers can properly announce this element.
Suggested change
| <div className={cx(containerStyles, isDarkMode && darkModeContainerStyles)}> | |
| <div | |
| className={cx(containerStyles, isDarkMode && darkModeContainerStyles)} | |
| role="dialog" | |
| aria-label="Diagram Editor Side Panel" | |
| > |
Copilot uses AI. Check for mistakes.
| @@ -332,6 +335,10 @@ const DiagramEditor: React.FunctionComponent<{ | |||
| title={diagramLabel} | |||
| edges={edges} | |||
| nodes={areNodesReady ? nodes : []} | |||
| onEdgeClick={() => { | |||
| // TODO: we have to open a side panel with edge details | |||
There was a problem hiding this comment.
[nitpick] The TODO comment is now outdated since onOpenSidePanel is implemented. Please update or remove this comment to keep the code clean.
Suggested change
| // TODO: we have to open a side panel with edge details |
Copilot uses AI. Check for mistakes.
mabaasit
added
feature flagged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add diagram editor side panel. Currently open when an edge is clicked.
Preview
SidePanel.mov
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes