fix: updates count tool #254
Conversation
| query: z | ||
| .record(z.string(), z.unknown()) | ||
| .optional() | ||
| .describe("Alternative old name for filter. Will be used in db.collection.countDocuments()"), |
There was a problem hiding this comment.
is there a reason to keep providing this field?
There was a problem hiding this comment.
yes, since the LLM was already confusing query/filter, I figure that it can get confused the other way around and try to send it as "query" because it thinks we'll use .count() (even though we call out is countDocments, but who knows, it might have outdated data about MDB)
There was a problem hiding this comment.
This doesn't make much sense to me. I think we should tweak the description of filter rather than accept two arguments that are doing the same thing.
There was a problem hiding this comment.
np, I'll remove and update the description
There was a problem hiding this comment.
we can try that for now and see if it improves, based on the issue I'm not sure the LLM will stop getting confused
countDocuments()queryorfilterin the tool, since LLMs might get confused about the right argument to use