REP-6940 Prevent spurious slow-query warnings for collection partitioning. #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when partitioning we weren’t notifying the retryer of intermediate successes. As a result we would see logs like this for large collections:
{code}
2025-12-19T02:34:18Z WRN Operation has not reported success for a while. description=["partitioning
test.sequentialID_2000"] elapsedTime="9m 0s" noSuccessSince=2025-12-19T02:25:18Z successesSoFar=0{code}
… which looks like something is running too slowly.
In reality, this is expected behavior for large collections because partitioning those just takes a long time.
This changeset fixes the spurious logs by adding a NoteSuccess() every time we add a new partition.