added support for backup #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaskawi
reviewed
Nov 6, 2023
| autoTerminateOnDeletion: false | ||
| encryption: | ||
| kmip: | ||
| client: |
There was a problem hiding this comment.
This might be a bad idea as MEKO turns KMIP on and off based on the existence of the .spec.encryption.kmip. Putting an empty element here might lead to errors.
There was a problem hiding this comment.
Added validation to verify whether encryption is enabled or not in the charts/templates/mongodb-deployment.yaml file.
| kmip: | ||
| client: | ||
| clientCertificatePrefix: "" | ||
| snapshotSchedule: |
There was a problem hiding this comment.
Just for the record, the same thing happens here. Providing empty values is not the same as not providing this at all.
There was a problem hiding this comment.
Also added validation to verify if value of clientCertificatePrefix is empty string, then to not include encryption block at all.
…validation for clientCertificatePrefix value to be not empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.