Adds Icon page back to .design #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bruugey
commented
Jun 10, 2024
•
bruugey
commented
- Updates to use latest version of all LG components
- Max width for design docs pages is 700px
stephl3
reviewed
Jun 10, 2024
There was a problem hiding this comment.
understandable if we opt not to prioritize mobile breakpoints but should we still have responsiveness until the 1024px?
seems like a solution could be to update the grid-template-columns value in the Icon.stories.tsx file to repeat(4, 1fr). at that point, it could also make sense to add a fixed-height w/ scroll
stephl3
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.