Table sticky scroll shadow
#2541
Open
+446
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruugey
reviewed
Nov 11, 2024
packages/table/src/Table.stories.tsx
Outdated
| @@ -312,7 +307,8 @@ export const HundredsOfRows: StoryFn<StoryTableProps> = args => { | |||
| const { rows } = table; | |||
|
|
|||
| return ( | |||
| <> | |||
| <div> | |||
| <div style={{ height: '50px' }} /> | |||
There was a problem hiding this comment.
no particular reason, i'll update
bruugey
reviewed
Nov 11, 2024
packages/table/src/Table.stories.tsx
Outdated
| @@ -364,7 +359,8 @@ export const HundredsOfRows: StoryFn<StoryTableProps> = args => { | |||
| })} | |||
| </TableBody> | |||
| </Table> | |||
| </> | |||
| <div style={{ height: '2000px' }} /> | |||
bruugey
reviewed
Nov 11, 2024
Base automatically changed from
shaneeza/table-memoized
to
table-refactor-integration
November 18, 2024 20:06
stephl3
reviewed
Nov 18, 2024
| @@ -0,0 +1,195 @@ | |||
| import React, { Fragment, useState } from 'react'; | |||
There was a problem hiding this comment.
file name typo: Table.Interactions.stories.tsx *
| title: 'Components/Table/Interactions', | ||
| component: Table, | ||
| argTypes: { | ||
| shouldAlternateRowColor: { control: 'boolean' }, |
There was a problem hiding this comment.
I don't think this control is working
Also, should we add the darkMode toggle? Was looking to check the dark mode UI for the box-shadow
Comment on lines
+305
to
+310
| <div> | ||
| <div | ||
| className={css` | ||
| height: 50px; | ||
| `} | ||
| /> |
There was a problem hiding this comment.
Wondering if I need to test this story as well since I see changes here. Or should I only be checking Interactions/StickyHeader?
There was a problem hiding this comment.
it's sorta the same, however, i think i might be able to remove this
Comment on lines
+61
to
+62
| {/* Empty div used to track if the header is sticky */} | ||
| <div ref={ref} /> |
There was a problem hiding this comment.
can we merge the ref from useInView with the containerRef to avoid adding an empty div?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-3679
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes
All failing tests will be updated in a separate PR.