CDRIVER-5644 Add option to configure DEK cache lifetime #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
reviewed
Nov 6, 2024
kevinAlbs
reviewed
Nov 13, 2024
| @@ -0,0 +1,27 @@ | |||
| :man_page: mongoc_auto_encryption_opts_set_key_expiration | |||
There was a problem hiding this comment.
Add mongoc_auto_encryption_opts_set_key_expiration to the toctree of mongoc_auto_encryption_opts_t.rst to include in the docs. Fixes error from the docs build:
mongoc_auto_encryption_opts_set_key_expiration.rst:document isn't included in any toctree
CONTRIBUTING.md documents how to build docs locally. To build libmongoc docs, I use:
DIR=src/libmongoc/doc
OUTDIR=cmake-build/src/libmongoc/doc/html
poetry run sphinx-autobuild -b html $DIR $OUTDIR --re-ignore ".*.pickle" --re-ignore ".*.doctree" -j auto --port 9000 -W| @@ -0,0 +1,27 @@ | |||
| :man_page: mongoc_client_encryption_opts_set_key_expiration | |||
There was a problem hiding this comment.
Add mongoc_client_encryption_opts_set_key_expiration to the toctree of mongoc_client_encryption_opts_t.rst to include in the docs.
| @@ -1428,6 +1429,13 @@ _mongoc_crypt_new (const bson_t *kms_providers, | |||
| goto fail; | |||
| } | |||
|
|
|||
| if (cache_expiration_ms.set) { | |||
| mongocrypt_setopt_key_expiration (crypt->handle, cache_expiration_ms.value); | |||
There was a problem hiding this comment.
Suggest doing git merge master to update compile-libmongocrypt.sh to use libmongocrypt 1.12.0. libmongocrypt 1.12.0 contains the needed mongocrypt_setopt_key_expiration symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[still needs a unified test using ClientEncryption, otherwise ready]