Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL-2463: update release instructions for odbc #266

Open
wants to merge 5 commits into
base: on-prem-eap
Choose a base branch
from

Conversation

terakilobyte
Copy link
Member

No description provided.

Copy link
Collaborator

@pmeredit pmeredit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

RELEASE.md Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
@terakilobyte
Copy link
Member Author

terakilobyte commented Nov 14, 2024

@nbagnard I added more information about the tag format, reinforced with an example.

Copy link
Collaborator

@nbagnard nbagnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have 2 remaining questions, for my own sake, in trying to make sure I have the correct thing in mind and we won't miss things when merging back to master.

RELEASE.md Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
git tag -a -m X.Y.Z vX.Y.Z

```sh
#git tag -am X.Y.Z[-<ODBCprerelease>]-libvXX.YY.ZZ[-<prerelease>]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#git tag -am X.Y.Z[-<ODBCprerelease>]-libvXX.YY.ZZ[-<prerelease>]
#git tag -am X.Y.Z[-<ODBCprerelease>]-libvXX.YY.ZZ[-<prerelease>]
# For example :

Copy link
Collaborator

@nbagnard nbagnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just realized that it's not called out anywhere else.
Can we make sure that it is clear that a libmongosqltranslate version change trigger a patch version bump on the driver side, please.

RELEASE.md Outdated
@@ -3,22 +3,31 @@
This document describes the version policy and release process for the MongoDB Atlas SQL interface ODBC Driver.

## Versioning
Versions will follow the [semantic versioning](https://semver.org/) system.

Versions will follow the [semantic versioning](https://semver.org/) system.
The following guidelines will be used to determine when each version component will be updated:
- **major**: backwards-breaking changes
- **minor**: functionality added in a backwards compatible manner
- **patch**: backwards compatible bug fixes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or libmongosqltranslate version update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants