PHPC-2478: Implement API for bulkWrite command #1763
Conversation
jmikola
force-pushed
the
1.x-phpc-2478
branch
from
985a161 to
7c6d456
Compare
jmikola
force-pushed
the
1.x-phpc-2478
branch
3 times, most recently
from
7a7b316 to
b1353e6
Compare
jmikola
force-pushed
the
1.x-phpc-2478
branch
2 times, most recently
from
cc280df to
d5d3c10
Compare
| PHONGO_BSON_INIT_STATE(state); | ||
| state.map.root.type = PHONGO_TYPEMAP_NATIVE_ARRAY; | ||
|
|
||
| /* TODO: Instead of converting the entire document, iterate BSON to obtain |
There was a problem hiding this comment.
Yep, using bson_iter_init_find and bson_iter_value is probably significantly faster than walking the entire BSON structure 👍
There was a problem hiding this comment.
Created PHPC-2516 to track this.
| return; | ||
| } | ||
|
|
||
| if (php_array_existsc(zoptions, "bypassDocumentValidation")) { |
There was a problem hiding this comment.
We do have some macros that we use for queries - would it make sense to make these macros universal? I'm thinking of something like this:
PHONGO_EXTRACT_OPTION_BOOL(zoptions, "bypassDocumentValidation", intern->bypass)
If so, I can create a ticket for this.
There was a problem hiding this comment.
I don't think there is sufficient overlap with the macros in Query.c to make that worthwhile. In Query, the parsed options go directly to a bson_t. Here, they're stashed on the object struct. For BulkWriteCommand's operation methods, they're going to be assigned via distinct setter methods (similar to most of the option handling in ClientEncryption.c).
It was possible to reuse WriteConcernError and WriteError with slight changes to their init functions.
This was not necessary for compilation, but it makes the header internally consistent.
Always return arrays for writeErrors and writeConcernErrors
jmikola
force-pushed
the
1.x-phpc-2478
branch
from
d5d3c10 to
88e2508
Compare
jmikola
force-pushed
the
1.x-phpc-2478
branch
2 times, most recently
from
7542cba to
3a45310
Compare
Per CDRIVER-5843, libmongoc does not consistently populate this field. It also isn't required by the spec, so omit it for now.
jmikola
force-pushed
the
1.x-phpc-2478
branch
from
f65025a to
cd1622e
Compare
|
Superseded by #1790, which is rebased on v2.x. |
https://jira.mongodb.org/browse/PHPC-2478