PHPLIB-1609 Don't mandate the use of "distanceField" in $geoNear
#1569
Conversation
The $geoNear distanceField argument is now optional for queries on non-timeseries collections.
| @@ -265,8 +265,8 @@ public static function fill( | |||
| * Default: false. | |||
| */ | |||
| public static function geoNear( | |||
| string $distanceField, | |||
There was a problem hiding this comment.
The parameter was put first because required parameters must be before the optional ones. Changing the order of the parameters would be a breaking change one the library is released.
There was a problem hiding this comment.
I worry that the server being able to make such changes at will (where we might require a BC break to maintain consistency) is going to inevitably become a problem down the line.
Had you not caught this before a release, how could PHPLIB-1609 have been implemented?
| @@ -265,8 +265,8 @@ public static function fill( | |||
| * Default: false. | |||
| */ | |||
| public static function geoNear( | |||
| string $distanceField, | |||
There was a problem hiding this comment.
I worry that the server being able to make such changes at will (where we might require a BC break to maintain consistency) is going to inevitably become a problem down the line.
Had you not caught this before a release, how could PHPLIB-1609 have been implemented?
Fix PHPLIB-1609 see DRIVERS-3071
The
$geoNeardistanceField argument is now optional for queries on non-timeseries collections.