Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock drivers-evergreen-tools version #1578

Closed
wants to merge 1 commit into from

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jan 28, 2025

Lock evergreen tools version, as the commit mongodb-labs/drivers-evergreen-tools@50d13ab broke the build.

This can be reverted once fixed by #1577

@GromNaN GromNaN requested a review from a team as a code owner January 28, 2025 19:40
@GromNaN GromNaN requested a review from jmikola January 28, 2025 19:40
@@ -67,7 +67,7 @@ jobs:
python-version: '3.13'

- id: setup-mongodb
uses: mongodb-labs/drivers-evergreen-tools@master
uses: mongodb-labs/drivers-evergreen-tools@6a0686e0194d30b0a259404839c3e8bf9be12a5b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually work? My understanding from @alcaeus' comments in the meeting this morning was that we couldn't use a commit hash here and would need to resort to a submodule.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue it that we cannot use dependabot to track new versions.

For each action in the file, Dependabot checks the action’s reference (typically a version number or commit identifier associated with the action)
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot#about-dependabot-version-updates-for-actions

I tried previously.
image

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM until we have a better fix.

@alcaeus
Copy link
Member

alcaeus commented Jan 29, 2025

@GromNaN can you make the same change in PHPC please?

@GromNaN
Copy link
Member Author

GromNaN commented Jan 29, 2025

The fix is ready: mongodb-labs/drivers-evergreen-tools#584

@jmikola
Copy link
Member

jmikola commented Jan 29, 2025

The fix is ready: mongodb-labs/drivers-evergreen-tools#584

@GromNaN: Does this mean that this PR is no longer necessary? I noticed that my PHPC PRs started passing after the above fix was merged to drivers-evergreen-tools.

@GromNaN
Copy link
Member Author

GromNaN commented Jan 29, 2025

Yes, this PR is no longer necessary.

@GromNaN GromNaN closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants