Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-4183: Improve changelog entry for breaking SON -> dict change in PYTHON-2884 #1498

Merged
merged 7 commits into from
Feb 5, 2024
Merged

PYTHON-4183: Improve changelog entry for breaking SON -> dict change in PYTHON-2884 #1498

merged 7 commits into from
Feb 5, 2024

Conversation

Jibola
Copy link
Contributor

@Jibola Jibola commented Feb 1, 2024

No description provided.

@Jibola Jibola changed the title PYTHON-4183: Unavoidable breaking change with BSON PYTHON-4183: Document Unavoidable breaking change with BSON Feb 1, 2024
@Jibola Jibola changed the title PYTHON-4183: Document Unavoidable breaking change with BSON PYTHON-4183: Document "Unavoidable breaking change" from PYTHON-2884 Feb 1, 2024
@Jibola Jibola changed the title PYTHON-4183: Document "Unavoidable breaking change" from PYTHON-2884 PYTHON-4183: Update changelog on to identify "Unavoidable breaking change" from PYTHON-2884 Feb 1, 2024
@Jibola Jibola marked this pull request as ready for review February 1, 2024 21:35
@Jibola Jibola requested a review from a team as a code owner February 1, 2024 21:35
@Jibola Jibola requested review from blink1073 and removed request for a team February 1, 2024 21:35
blink1073
blink1073 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShaneHarvey ShaneHarvey self-requested a review February 1, 2024 22:57
@ShaneHarvey ShaneHarvey mentioned this pull request Feb 1, 2024
Merged
ShaneHarvey
ShaneHarvey requested changes Feb 1, 2024
View reviewed changes
doc/changelog.rst Outdated Show resolved Hide resolved
@ShaneHarvey ShaneHarvey changed the title PYTHON-4183: Update changelog on to identify "Unavoidable breaking change" from PYTHON-2884 PYTHON-4183: Improve changelog entry for breaking SON -> dict change in PYTHON-2884 Feb 2, 2024
Jibola
Jibola commented Feb 5, 2024
View reviewed changes
doc/changelog.rst Outdated Show resolved Hide resolved
@Jibola
Copy link
Contributor Author

Jibola commented Feb 5, 2024 •
edited
Loading

Failures are unrelated to my change. https://jira.mongodb.org/browse/PYTHON-4182

@Jibola Jibola merged commit 62c3cb1 into mongodb:master Feb 5, 2024
72 of 75 checks passed
@Jibola Jibola deleted the PYTHON-4183 branch February 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jibola @blink1073 @ShaneHarvey