Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-4494 - AsyncMongoClient._cleanup_cursor needs to be synchronous #1680

Merged
merged 3 commits into from
Jun 17, 2024
Merged

PYTHON-4494 - AsyncMongoClient._cleanup_cursor needs to be synchronous #1680

merged 3 commits into from
Jun 17, 2024

Conversation

NoahStapp
Copy link
Contributor

No description provided.

ShaneHarvey
ShaneHarvey previously approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ShaneHarvey
ShaneHarvey reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix this line in the CommandCursor constructer as well?:

        if _IS_SYNC and self._killed:
            self._end_session(True)  # type: ignore[unused-coroutine]

@NoahStapp
Copy link
Contributor Author

if _IS_SYNC and self._killed:

Good catch, thanks! Fixed.

@NoahStapp NoahStapp merged commit 1f910b5 into mongodb:master Jun 17, 2024
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@Jibola Jibola Awaiting requested review from Jibola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoahStapp @ShaneHarvey