PYTHON-4525 Transition the existing test_database.py test to be asynchronous #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
requested changes
Jun 26, 2024
Contributor
NoahStapp
left a comment
NoahStapp
left a comment
There was a problem hiding this comment.
A few suggested fixes for the typechecking failures, but great start!
shruti-sridhar
force-pushed
the
PYTHON-4525
branch
from
7860e51 to
34b0e69
Compare
NoahStapp
requested changes
Jun 27, 2024
Contributor
NoahStapp
left a comment
NoahStapp
left a comment
There was a problem hiding this comment.
A few more cleanup and typing fixes.
Contributor
@shruti-sridhar #1718 is merged, go ahead and rebase these changes onto master to resolve the merge conflict. |
shruti-sridhar
force-pushed
the
PYTHON-4525
branch
from
957a8d1 to
56f35e7
Compare
NoahStapp
requested changes
Jul 2, 2024
Contributor
NoahStapp
left a comment
NoahStapp
left a comment
There was a problem hiding this comment.
A few cleanup comments, but otherwise looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the existing
test/test_database.pytest to be asynchronous and generates the synchronous version.