Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-4851 - Convert test.test_csot to async #1921

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 114 additions & 0 deletions test/asynchronous/test_csot.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
# Copyright 2022-present MongoDB, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""Test the CSOT unified spec tests."""
from __future__ import annotations

import os
import pathlib
import sys

sys.path[0:0] = [""]

from test.asynchronous import AsyncIntegrationTest, async_client_context, unittest
from test.asynchronous.unified_format import generate_test_classes

import pymongo
from pymongo import _csot
from pymongo.errors import PyMongoError

_IS_SYNC = False

# Location of JSON test specifications.
if _IS_SYNC:
_TEST_PATH = os.path.join(pathlib.Path(__file__).resolve().parent, "csot")
else:
_TEST_PATH = os.path.join(pathlib.Path(__file__).resolve().parent.parent, "csot")

# Generate unified tests.
globals().update(generate_test_classes(_TEST_PATH, module=__name__))


class TestCSOT(AsyncIntegrationTest):
RUN_ON_SERVERLESS = True
RUN_ON_LOAD_BALANCER = True

async def test_timeout_nested(self):
coll = self.db.coll
self.assertEqual(_csot.get_timeout(), None)
self.assertEqual(_csot.get_deadline(), float("inf"))
self.assertEqual(_csot.get_rtt(), 0.0)
with pymongo.timeout(10):
await coll.find_one()
self.assertEqual(_csot.get_timeout(), 10)
deadline_10 = _csot.get_deadline()

# Capped at the original 10 deadline.
with pymongo.timeout(15):
await coll.find_one()
self.assertEqual(_csot.get_timeout(), 15)
self.assertEqual(_csot.get_deadline(), deadline_10)

# Should be reset to previous values
self.assertEqual(_csot.get_timeout(), 10)
self.assertEqual(_csot.get_deadline(), deadline_10)
await coll.find_one()

with pymongo.timeout(5):
await coll.find_one()
self.assertEqual(_csot.get_timeout(), 5)
self.assertLess(_csot.get_deadline(), deadline_10)

# Should be reset to previous values
self.assertEqual(_csot.get_timeout(), 10)
self.assertEqual(_csot.get_deadline(), deadline_10)
await coll.find_one()

# Should be reset to previous values
self.assertEqual(_csot.get_timeout(), None)
self.assertEqual(_csot.get_deadline(), float("inf"))
self.assertEqual(_csot.get_rtt(), 0.0)

@async_client_context.require_change_streams
async def test_change_stream_can_resume_after_timeouts(self):
coll = self.db.test
await coll.insert_one({})
async with await coll.watch() as stream:
with pymongo.timeout(0.1):
with self.assertRaises(PyMongoError) as ctx:
await stream.next()
self.assertTrue(ctx.exception.timeout)
self.assertTrue(stream.alive)
with self.assertRaises(PyMongoError) as ctx:
await stream.try_next()
self.assertTrue(ctx.exception.timeout)
self.assertTrue(stream.alive)
# Resume before the insert on 3.6 because 4.0 is required to avoid skipping documents
if async_client_context.version < (4, 0):
await stream.try_next()
await coll.insert_one({})
with pymongo.timeout(10):
self.assertTrue(await stream.next())
self.assertTrue(stream.alive)
# Timeout applies to entire next() call, not only individual commands.
with pymongo.timeout(0.5):
with self.assertRaises(PyMongoError) as ctx:
await stream.next()
self.assertTrue(ctx.exception.timeout)
self.assertTrue(stream.alive)
self.assertFalse(stream.alive)


if __name__ == "__main__":
unittest.main()
2 changes: 1 addition & 1 deletion test/asynchronous/unified_format.py
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ async def _databaseOperation_listCollections(self, target, *args, **kwargs):
if "batch_size" in kwargs:
kwargs["cursor"] = {"batchSize": kwargs.pop("batch_size")}
cursor = await target.list_collections(*args, **kwargs)
return list(cursor)
return await cursor.to_list()

async def _databaseOperation_createCollection(self, target, *args, **kwargs):
# PYTHON-1936 Ignore the listCollections event from create_collection.
Expand Down
10 changes: 8 additions & 2 deletions test/test_csot.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from __future__ import annotations

import os
import pathlib
import sys

sys.path[0:0] = [""]
Expand All @@ -27,11 +28,16 @@
from pymongo import _csot
from pymongo.errors import PyMongoError

_IS_SYNC = True

# Location of JSON test specifications.
TEST_PATH = os.path.join(os.path.dirname(os.path.realpath(__file__)), "csot")
if _IS_SYNC:
_TEST_PATH = os.path.join(pathlib.Path(__file__).resolve().parent, "csot")
else:
_TEST_PATH = os.path.join(pathlib.Path(__file__).resolve().parent.parent, "csot")

# Generate unified tests.
globals().update(generate_test_classes(TEST_PATH, module=__name__))
globals().update(generate_test_classes(_TEST_PATH, module=__name__))


class TestCSOT(IntegrationTest):
Expand Down
2 changes: 1 addition & 1 deletion test/unified_format.py
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ def _databaseOperation_listCollections(self, target, *args, **kwargs):
if "batch_size" in kwargs:
kwargs["cursor"] = {"batchSize": kwargs.pop("batch_size")}
cursor = target.list_collections(*args, **kwargs)
return list(cursor)
return cursor.to_list()

def _databaseOperation_createCollection(self, target, *args, **kwargs):
# PYTHON-1936 Ignore the listCollections event from create_collection.
Expand Down
1 change: 1 addition & 0 deletions tools/synchro.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ def async_only_test(f: str) -> bool:
"test_connection_logging.py",
"test_connections_survive_primary_stepdown_spec.py",
"test_crud_unified.py",
"test_csot.py",
"test_cursor.py",
"test_database.py",
"test_encryption.py",
Expand Down
Loading