PYTHON-3096 Finish implementation and tests for GSSAPI options #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Nov 16, 2024
| af, socktype, proto, canonname, sockaddr = socket.getaddrinfo( | ||
| hostname, None, 0, 0, socket.IPPROTO_TCP, socket.AI_CANONNAME | ||
| )[0] | ||
|
|
||
| # For forward just to resolve the cname as dns.lookup() will not return it. | ||
| if option == "forward": |
There was a problem hiding this comment.
It looks like the string "none" is also valid:
def _validate_canonicalize_host_name(value: str | bool) -> str | bool:
valid_names = [False, True, "none", "forward", "forwardAndReverse"]
Should that have the same behavior as False? Or should validate convert "none" to False?
There was a problem hiding this comment.
I changed it to convert "none" to false, so the three validated options are True, False, and "forward".
There was a problem hiding this comment.
Actually no, the spec test is expecting it to validate as a string, so I updated the business logic instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.