Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-4721 - Create individualized scripts for all shell.exec commands #1997

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

NoahStapp
Copy link
Contributor

@NoahStapp NoahStapp commented Nov 7, 2024

OCSP and AWS Auth tests are still failing.

@NoahStapp NoahStapp requested review from blink1073 and removed request for blink1073 November 7, 2024 18:57
@NoahStapp NoahStapp marked this pull request as draft November 7, 2024 18:58
@blink1073
Copy link
Member

We need to handle SKIP_CSOT_TESTS as well.

@blink1073 blink1073 self-requested a review November 7, 2024 21:23
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Show resolved Hide resolved

"run-ocsp-server":
- command: subprocess.exec
params:
background: true
binary: bash
include_expansions_in_env: [SERVER_TYPE, OCSP_ALGORITHM]
include_expansions_in_env: ["SERVER_TYPE", "OCSP_ALGORITHM"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need quotes for these in general unless they have an expansion.

else
git clone https://github.com/mongodb-labs/drivers-evergreen-tools.git $DRIVERS_TOOLS
fi
echo "{ \"releases\": { \"default\": \"$MONGODB_BINARIES\" }}" >$MONGO_ORCHESTRATION_HOME/orchestration.config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.evergreen/scripts/run-ocsp-test.sh Show resolved Hide resolved

. .evergreen/scripts/env.sh
if [ -n "${test_encryption}" ]; then
./.evergreen/hatch.sh encryption:setup &
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to break this out the way we handle it in the go driver, as a separate background command: https://github.com/mongodb/mongo-go-driver/blob/cf0348c9a63f6e4086e2c62aa62e70a9d3b3a986/.evergreen/config.yml#L508

.evergreen/scripts/teardown-aws.sh Show resolved Hide resolved
.evergreen/config.yml Outdated Show resolved Hide resolved
@NoahStapp NoahStapp marked this pull request as ready for review November 12, 2024 16:14
blink1073
blink1073 previously approved these changes Nov 12, 2024
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I scheduled several other variants to make sure all is well.

@blink1073
Copy link
Member

It looks like "upload mo artifacts" is causing teardown failures.

@blink1073
Copy link
Member

The encryption servers still need handling: [2024/11/12 14:07:25.482] Could not detect PID file

@NoahStapp
Copy link
Contributor Author

The encryption servers still need handling: [2024/11/12 14:07:25.482] Could not detect PID file

Looking into this one, it's oddly inconsistent.

@blink1073
Copy link
Member

FYI I added Encryption RHEL8 Python3.10 to the default tasks that run.

@blink1073
Copy link
Member

blink1073 commented Nov 14, 2024

I scheduled a cross-section of build variants, there were a few failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants