-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-4721 - Create individualized scripts for all shell.exec commands #1997
base: master
Are you sure you want to change the base?
Conversation
We need to handle |
.evergreen/config.yml
Outdated
|
||
"run-ocsp-server": | ||
- command: subprocess.exec | ||
params: | ||
background: true | ||
binary: bash | ||
include_expansions_in_env: [SERVER_TYPE, OCSP_ALGORITHM] | ||
include_expansions_in_env: ["SERVER_TYPE", "OCSP_ALGORITHM"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need quotes for these in general unless they have an expansion.
else | ||
git clone https://github.com/mongodb-labs/drivers-evergreen-tools.git $DRIVERS_TOOLS | ||
fi | ||
echo "{ \"releases\": { \"default\": \"$MONGODB_BINARIES\" }}" >$MONGO_ORCHESTRATION_HOME/orchestration.config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make the call to https://github.com/mongodb-labs/drivers-evergreen-tools/blob/master/.evergreen/setup.sh in this file.
.evergreen/scripts/run-tests.sh
Outdated
|
||
. .evergreen/scripts/env.sh | ||
if [ -n "${test_encryption}" ]; then | ||
./.evergreen/hatch.sh encryption:setup & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to break this out the way we handle it in the go driver, as a separate background command: https://github.com/mongodb/mongo-go-driver/blob/cf0348c9a63f6e4086e2c62aa62e70a9d3b3a986/.evergreen/config.yml#L508
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I scheduled several other variants to make sure all is well.
It looks like "upload mo artifacts" is causing teardown failures. |
The encryption servers still need handling: |
Looking into this one, it's oddly inconsistent. |
FYI I added |
I scheduled a cross-section of build variants, there were a few failures |
OCSP and AWS Auth tests are still failing.