RUBY-3357 SSDLC Requirements #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, add a cleanup workflow for use while testing
this is temporary until silk is able to grab the correct sbom lite from the mongo-ruby-driver repo
and for testing, remove dry-run from s3 upload, to make sure it works
alcaeus
reviewed
Jun 24, 2024
.github/workflows/release.yml
Outdated
Comment on lines
7
to
10
| dry_run: | ||
| description: Whether this is a dry run or not ("false" to deploy) | ||
| required: true | ||
| type: string |
There was a problem hiding this comment.
Inputs for workflow_dispatch support a boolean type which will be rendered as a checkbox: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#providing-inputs
Consider this:
Suggested change
| dry_run: | |
| description: Whether this is a dry run or not ("false" to deploy) | |
| required: true | |
| type: string | |
| dry_run: | |
| description: Whether this is a dry run or not | |
| required: true | |
| type: boolean |
There was a problem hiding this comment.
Oh, that's good to know! I'll give that a try.
This is so it gets rendered as a checkbox. We'll default it to `true` to avoid accidental releases.
alcaeus
approved these changes
Jun 27, 2024
comandeo-mongo
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
With these working in the driver, it should be fairly straighforward to implement these in our other Ruby projects as well.