RUST-2181 Fix rustup installation on windows #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
force-pushed
the
RUST-2181/windows-rustup
branch
from
0c3da9a to
cf138d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2181
This works around the cygwin symlink bug (rust-lang/rustup#4239) with a small script that replaces the symlinks with actual copies. This wouldn't be a good workaround for a long-lived installation because it'd mess with the rustup upgrade process, but because we're doing a clean install every time and then discarding it once tests are done it's fine here.
I went with python for the script rather than bash because I think it ends up being substantially more readable.