Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make script executable and add ignored folder #276

Merged
merged 1 commit into from
Mar 5, 2024
Merged

make script executable and add ignored folder #276

merged 1 commit into from
Mar 5, 2024

Conversation

nammn
Copy link
Collaborator

@nammn nammn commented Mar 5, 2024 •
edited
Loading

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Summary

  • During local testing I realized that paths were wrong and the script was not execuable
  • Additionally adding the file under .gitignore enables local testing

@nammn nammn marked this pull request as ready for review March 5, 2024 08:40
@nammn nammn merged commit b0a80fa into master Mar 5, 2024
@nammn nammn deleted the other-missing-things branch April 29, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mircea-cosbuc mircea-cosbuc Awaiting requested review from mircea-cosbuc mircea-cosbuc is a code owner

@lsierant lsierant Awaiting requested review from lsierant lsierant is a code owner

@slaskawi slaskawi Awaiting requested review from slaskawi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nammn