Fix logging to stdout

[schans]

Allow for setting logFile to /dev/stdout for logging to stdout. Log settings are set directly in the mongodb-agent comment instead of passing through the environment (which is not the most secure way).

All Submissions:

• Have you opened an Issue before filing this PR?
• Have you signed our CLA?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

[schans]

This addresses #1439

closes #1439

[slaskawi]

Let me assign this to @lsierant for review

[schans]

Thanks!

[schans]

Hi @lsierant ,

Please don't hesitate to reach out to me if you need some extra info or if you would like some update to the PR. I'm happy to work with you to find a solution for this as it is blocking our upgrades to newer mongo versions.

Thanks
Bart

[schans]

Noticed the unit test failed. I probably overlooked something there. I will update the PR

Run go test -v ./controllers/...
# github.com/mongodb/mongodb-kubernetes-operator/controllers/construct [github.com/mongodb/mongodb-kubernetes-operator/controllers/construct.test]
Error: controllers/construct/build_statefulset_test.go:18[4](https://github.com/mongodb/mongodb-kubernetes-operator/actions/runs/7858171594/job/21809088638?pr=1489#step:6:5):19: undefined: agentLogFileEnv
Error: controllers/construct/build_statefulset_test.go:18[6](https://github.com/mongodb/mongodb-kubernetes-operator/actions/runs/7858171594/job/21809088638?pr=1489#step:6:7):19: undefined: agentLogLevelEnv
Error: controllers/construct/build_statefulset_test.go:188:19: undefined: agentMaxLogFileDurationHoursEnv

[schans]

Updated unit test. Instead of testing for the env variables it now test for the construction of the agent command.

[schans]

Sorry. Missed the env count check, should be all green now.

[schans]

Hi @slaskawi and @lsierant,

Thank you for all your support so far. Please let me know how I can help to get this merged/fixed!

[nammn]

LGTM and thanks for your contribution!

[nammn]

From a reading perspective I prefer the inverse:

if logFile == ...{}

else:
{}

[legal90]

@schans Thank you for fixing this issue! 👍

@nammn Do you have any estimates when there could be a new version of community operator with this fix included? Thanks!

[nammn]

@legal90 there are plans to release in about 2-3 weeks
cc. @dan-mckean

[uttammeena]

@legal90 there are plans to release in about 2-3 weeks cc. @dan-mckean

Any date in sight for this release?

[jlestrange]

Hi @nammn

Any update on when this is going to be released, we need this update to be able to use the latest version of the app?

Thanks

[nammn]

@jlestrange @uttammeena @legal90 @laiminhtrung1997 sorry for the late reply and release, but its out now!
https://github.com/mongodb/mongodb-kubernetes-operator/releases/tag/v0.10.0

[laiminhtrung1997]

Dear @nammn @schans
I’m currently utilizing MongoDB Operator version 0.9.0 and have configured the agent.logFile to /dev/stdout. As per my understanding from issue #1439, all log levels will now be directed to stdout instead of just agent.logLevel: INFO, correct? If that’s the case, wouldn’t this lead to the occurrence of issue #1226? Could you please help me confirm this?

[nammn]

Hey @laiminhtrung1997

• if configured to stdout all loglevels will go to stdout
• no, the volume shouldn't fill up - since all logs go to stdout and not to a file, can you clarify what you mean?

[laiminhtrung1997]

Dear @nammn
Sorry for my silly question, I want to ensure the issue from #1226 has not occurred in my environment. Thanks for your quick reply.