Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-155037 - ensure we are waiting for some time until all the agents have finished updating the ports #1506

Merged
merged 1 commit into from
Mar 25, 2024
Merged

CLOUDP-155037 - ensure we are waiting for some time until all the agents have finished updating the ports #1506

merged 1 commit into from
Mar 25, 2024
+16 −6

Conversation

nammn
Copy link
Collaborator

@nammn nammn commented Mar 7, 2024 •
edited
Loading

Summary:

  • making sure we wait and retry for some time until we fail the port change test. More description is in the method which has changed.

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@nammn nammn changed the title make ensuring a poll ensure we are waiting for some time until all the agents have finished updating the ports Mar 7, 2024
@nammn nammn marked this pull request as ready for review March 7, 2024 09:36
@nammn nammn changed the title ensure we are waiting for some time until all the agents have finished updating the ports CLOUDP-155037 - ensure we are waiting for some time until all the agents have finished updating the ports Mar 7, 2024
@nammn nammn merged commit 2b18764 into master Mar 25, 2024
42 checks passed
@nammn nammn deleted the fix-flaky-test branch March 25, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaskawi slaskawi

@mircea-cosbuc mircea-cosbuc

@lsierant lsierant

@Julien-Ben Julien-Ben

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nammn @slaskawi