🚀 [READY FOR REVIEW] MONGOID-5559 - Bugfix: BigDecimal should include Mongoid::Criteria::Queryable::Extensions::Numeric #5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
johnnyshields
changed the title
|
@Neilshweky @comandeo ready for review. |
johnnyshields
changed the title
johnnyshields
changed the title
johnnyshields
changed the title
johnnyshields
commented
Feb 10, 2023
| @@ -79,3 +79,5 @@ def evolve(object) | |||
|
|
|||
| ::Float.__send__(:include, Mongoid::Criteria::Queryable::Extensions::Numeric) | |||
| ::Float.__send__(:extend, Mongoid::Criteria::Queryable::Extensions::Numeric::ClassMethods) | |||
|
|
|||
| ::BigDecimal.__send__(:include, Mongoid::Criteria::Queryable::Extensions::Numeric) | |||
There was a problem hiding this comment.
extend ClassMethods not needed here since it mainly exists to define evolve which is done differently for BigDecimal already. (In the future, all this stuff typecasting stuff needs to be refactored.)
johnnyshields
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to MONGOID-5559.
The main effect of this is that BigDecimal will evolve correctly to Date/Time (as Integer/Float do today.)
Since BigDecimal is a numeric type, it should include the
Mongoid::Criteria::Queryable::Extensions::Numericmodule in case additional functionality is added in the future as well.