DOP-5744: TS - Chapters
#1467
Merged
DOP-5744: TS - Chapters
#1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-frontend-stg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rayangler
reviewed
Jun 25, 2025
ASteinheiser
approved these changes
Jun 26, 2025
Comment on lines
+137
to
+145
| const children = isString(data['description']) | ||
| ? ([{ type: 'text', value: data['description'] }] as TextNode[]) | ||
| : data['description']; | ||
|
|
||
| return { | ||
| type: 'directive', | ||
| name: 'card', | ||
| children: data['description'], | ||
| children, | ||
| argument: [], |
There was a problem hiding this comment.
Just curious, but this was typescript showing us a potential issue here?
There was a problem hiding this comment.
Yep! We've typed data.description as string | ASTNode[] but children has to be ASTNode[] - so we just have to make sure that if a string is the value it's turned into a TextNode.
🔄 Deploy Preview for docs-frontend-stg processing
|
rayangler
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-5744
Current Behavior:
Put a link to current staging or production behavior, if applicable
Staging Links:
Put a link to your staging environment(s), if applicable
Notes:
Typescriptify Chapters components.
Also, creates the
ASTNodetype.README updates