DOP-5509: offline composable tutorials #1474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-frontend-stg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-frontend-stg processing
|
mmeigs
reviewed
Jul 1, 2025
src/components/Select.tsx
Outdated
| return ( | ||
| <div className={cx(offlineMenuStyling, 'offline-select-menu')}> | ||
| <div | ||
| className={cx(offlineMenuStyling, className ? className : 'offline-select-menu')} |
There was a problem hiding this comment.
nit: Could use nullish coalescer className ?? 'offline-select-menu'
There was a problem hiding this comment.
(Also nit) Alternatively, I don't think they need to be mutually exclusive, but this might depend on use case.
className={cx(offlineMenuStyling, 'offline-select-menu', className)}There was a problem hiding this comment.
done! great callouts
rayangler
reviewed
Jul 1, 2025
src/components/Select.tsx
Outdated
| return ( | ||
| <div className={cx(offlineMenuStyling, 'offline-select-menu')}> | ||
| <div | ||
| className={cx(offlineMenuStyling, className ? className : 'offline-select-menu')} |
There was a problem hiding this comment.
(Also nit) Alternatively, I don't think they need to be mutually exclusive, but this might depend on use case.
className={cx(offlineMenuStyling, 'offline-select-menu', className)}
|
the staging links above have been updated with the latest commits! thank you for the great comments! PTAL |
rayangler
reviewed
Jul 2, 2025
rayangler
approved these changes
Jul 2, 2025
mmeigs
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-5509
Staging Links:
Offline doc is uploaded to S3 here. Download the file and open the page for an example of a composable tutorial that works offline
Staging link with env var
OFFLINE_DOCS=falsefor regression checks for online docsNotes:
README updates