DRIVERS-3419 - Test that client backpressure retries do not block oth…#1911
Merged
NoahStapp merged 2 commits intomongodb:masterfrom Mar 12, 2026
Merged
DRIVERS-3419 - Test that client backpressure retries do not block oth…#1911NoahStapp merged 2 commits intomongodb:masterfrom
NoahStapp merged 2 commits intomongodb:masterfrom
Conversation
NoahStapp
requested review from
jyemin and
kevinAlbs
and removed request for
a team
kevinAlbs
approved these changes
Mar 12, 2026
Contributor
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
Test LGTM with minor comments.
Unfortunately the C driver does not implement CMAP, so I do not expect this test applies to the C driver's quirky implementation (each client owns connections to server, so there is no checkout/checkin). That said, the C driver passes this test because the test runner ignores CMAP assertions.
Comment on lines
+27
to
+32
| initialData: | ||
| - collectionName: coll | ||
| databaseName: retryable-writes-tests | ||
| documents: | ||
| - _id: 1 | ||
| x: 11 |
Contributor
There was a problem hiding this comment.
I expect initialData is not needed since tested find expects to fail.
Suggested change
| initialData: | |
| - collectionName: coll | |
| databaseName: retryable-writes-tests | |
| documents: | |
| - _id: 1 | |
| x: 11 |
| - database: | ||
| id: database | ||
| client: client | ||
| databaseName: retryable-writes-tests |
Contributor
There was a problem hiding this comment.
Minor: use relevant database name
Suggested change
| databaseName: retryable-writes-tests | |
| databaseName: backpressure-connection-checkin |
| collectionName: coll | ||
| initialData: | ||
| - collectionName: coll | ||
| databaseName: retryable-writes-tests |
Contributor
There was a problem hiding this comment.
Suggested change
| databaseName: retryable-writes-tests | |
| databaseName: backpressure-connection-checkin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er operations
Please complete the following before merging:
Test changes in at least one language driver.Test changes only.clusters).