Fixed Control converter issue from user input #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marchant
commented
Mar 6, 2018
marchant
commented
- fixes a control bug with converter in revert so it works while editing
- adds a spec converter use cases for text field
- code re-factoring of rotation composer,
- fixes a control bug with converter in revert so it works while editing - adds a spec converter use cases for text field
hthetiot
reviewed
Mar 6, 2018
Contributor
hthetiot
left a comment
hthetiot
left a comment
There was a problem hiding this comment.
test/all.js: line 101, col 5, Expected ']' to match '[' from line 3 and instead saw '{'.
test/all.js: line 101, col 6, Expected ')' and instead saw 'name'.
test/all.js: line 101, col 10, Missing semicolon.
test/all.js
Outdated
| {name: "spec/ui/slot-spec", node: false}, | ||
| {name: "spec/ui/substitution-spec", node: false}, | ||
| {name: "spec/ui/text-input-spec", node: false}, | ||
| {name: "spec/ui/control/text-field-spec", node: false} |
Member
Author
|
Thanks @hthetiot pushed a fix |
Contributor
|
sry one more lint @benoitmarchant
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.