Skip to content

Conversation

@Stuk
Copy link
Contributor

@Stuk Stuk commented Nov 27, 2013

No description provided.

@Stuk
Copy link
Contributor Author

Stuk commented Nov 27, 2013

Could you review, @kriskowal?

@kriskowal
Copy link
Member

At the moment, Set uses Object.equals, but this is probably a bug. It should use Object.is, which does referential identity, which is to say === except that Object.is(NaN, NaN) and Object.is(-0, -0). Object.equals does a fancier kind of equivalence, where object and array literals with equivalent values are equivalent, and where objects that implement an equals method on their prototype can define their own notion of equivalence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants