-
Notifications
You must be signed in to change notification settings - Fork 87
Add snippets source: community repository, targets #989 #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Menrath
wants to merge
15
commits into
moodle-an-hochschulen:main
Choose a base branch
from
Menrath:snippets_repo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change: refactor snippets code
Contributor
Author
|
The only tests failing seem not to be related with this PR, but with smartmenus instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the snippet community repository.
Also changed that the snippets file-comment is stripped in the enabled used snippet scss.
Thoughts for potential reviewers:
theme_boost_union_snippetstable. I decided for the first one, even though it seemed more non-moodle like, since the other solutions actually required even more logic (e.g. it would require the uploadedsnippets setting to use an extra file area!).classes/local/snippet.