Skip to content

Bugfix: adjust for subsections in courseindex handling, resolves #998 #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Bugfix: adjust for subsections in courseindex handling, resolves #998 #1084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions templates/core_courseformat/local/courseindex/cm.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,18 @@ if (document.body.classList.contains('hascourseindexcmicons')) {

// Or completion indication should be shown at the end of the line.
} else if (document.body.classList.contains('hascourseindexcpleol')) {
// Completion indication not shown at start of line anymore.
document.querySelectorAll('.courseindex-item[data-id="{{id}}"] span.completioninfo')[0].dataset.for = '_';
// Get completioninfo nodes for this courseindex item.
let completioninfonodes = document.querySelectorAll('.courseindex-item[data-id="{{id}}"] span.completioninfo');

// Check if there are any completioninfo nodes.
// There are no ones for courseindex item if the courseindex item is a subsection.
if (completioninfonodes) {
// Completion indication not shown at start of line anymore.
completioninfonodes[0].dataset.for = '_';

// The completion indication at the end of the line is now the active one.
document.querySelectorAll('.courseindex-item[data-id="{{id}}"] span.completioninfo')[2].dataset.for = 'cm_completion';
// The completion indication at the end of the line is now the active one.
completioninfonodes[2].dataset.for = 'cm_completion';
}
}
}

Expand Down
Loading