Improvement: make the back-to-top JS vanilla ES6 (jQuery free), resolves #119. #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menrath
force-pushed
the
issue-119
branch
2 times, most recently
from
f068343
to
fe99a6f
Compare
Menrath
changed the title
Menrath
changed the title
abias
force-pushed
the
main
branch
3 times, most recently
from
5696e9a
to
b9fa4ca
Compare
|
I just rebase the branch onto latest master / Moodle 4.5 to allow me to review it as soon as the tests are green again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue-119: #119
I also added a handwritten throttle function, the current setting of 200ms seemed reasonable for me, but I welcome any other thoughts on this.
Additionally one could also think of making the
scrollDistance(when the Button is shown) better configurable.