Bugfix: Course category breadcrumbs were broken on the course enrolment page due to MDL-80974 and were removed, resolves #727 #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt page due to MDL-80974 and were removed, resolves #727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the glitch which was reported in #727.
It was caused by a bug in Boost Union on the one hand, but also by the upstream change in MDL-80974 (see moodle/moodle@faac67e) on the other hand.
The PR's solution is to remove course category breadcrumbs from the enrolment page entirely as Boost Union in fact never promised to show them, they were rather shown there by chance.
The setting
theme_boost_union | categorybreadcrumbssays:Nothing is mentioned about the enrolment page. If category breadcrumbs are requested there, they have to be developed properly from scratch.