Skip to content

Bugfix: Smart menu: menu bar displayed although there are no items to display, resolves #849. #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

prasanna-lmsace
Copy link
Contributor

Included bootstrap responsive utility classes (d-md-none, d-md-flex, etc.) to control the visibility of the smart menu menubar based on the presence of child items.

@abias abias force-pushed the fix-empty-menubar branch from ec2faf8 to 2aaf472 Compare May 30, 2025 12:07
@abias abias self-assigned this May 30, 2025
@abias
Copy link
Member

abias commented May 30, 2025

Hi @prasanna-lmsace ,

many thanks for working on this issue!
You approach looks reasonable to me.

I reviewed the PHP part, but did not have a closer look at all the SCSS changes as the PR is still a draft and some tests were still failing.

So I have just rebased the PR onto latest main (which is BU 5.0 now) and have pushed it again to see if the failed test disappear magically ;)

May I ask you to give me some feedback about the status of this PR and when I can do a final review?

Many thanks in advance!

@prasanna-lmsace prasanna-lmsace marked this pull request as ready for review June 2, 2025 06:48
@prasanna-lmsace
Copy link
Contributor Author

Hi @abias

I’ve updated the test scenario outline "Smartmenus: Menu items: Presentation – Display the menu items in different viewports" by splitting it into individual scenarios to ensure the tests pass successfully.

With the scenario outline approach, the test attempted to open menus that were hidden due to having no items. To resolve this, I’ve separated them into distinct scenarios.

The pull request is now ready for your review.

Many Thanks!

@abias abias force-pushed the fix-empty-menubar branch from f894d14 to b4e0fbf Compare June 3, 2025 08:22
@abias abias force-pushed the fix-empty-menubar branch from b4e0fbf to 4f82f38 Compare July 25, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants