Improvement: Bring back the original hover effect in the language menu, resolves #803

[prasanna-lmsace]

No description provided.

[christianwolters]

Review

Following https://github.com/moodle-an-hochschulen/moodle-plugin-maintaining/wiki/Check-list-for-peer-reviewing-patches-and-pull-requests

Documentation

• Commit Message understandable and issue referenced (via resolves keyword)
• Patch author correct
• CHANGES.md appended
• README.md appended
• Credits appended
• Appropriate Comment quantity
• Successful Moodle PHPDoc check

version.php

• Checked if $plugin->version increment necessary (and increment done if necessary)
• $plugin->release untouched

lib.php

• Only necessary functions

Languages

• Only english strings
• Necessary magic strings added (e.g. capabilities)

Automated tests

• New functionality covered
• No failing steps or scenarios

Mustache templates

• Example context exists

CSS and styles.css

• Bootstrap styles used if possible

Duplicated code

• Duplicated code is marked properly

Github action

• All green

Commit history and scope

• Already single commit
• Focus on single purpose
• No surplus files

Additional aspects for Boost Union

• No usage of $theme->settings
• Usage of isset() checks when processing plugin settings in renderer / output code
• Usage of admin_setting_configselect instead of admin_setting_configcheckbox
• Modified mustache templates properly marked and .upstream template in place

Review result

• Tested again, works as aspected
• PR covers multiple issues, but in a valid scope

[christianwolters]

Cannot pushed rebased review version, conflicts only in Changes.MD and Version.PHP that have to be handled in merge.

[christianwolters]

Review

Following https://github.com/moodle-an-hochschulen/moodle-plugin-maintaining/wiki/Check-list-for-peer-reviewing-patches-and-pull-requests

Documentation

• Commit Message understandable and issue referenced (via resolves keyword)
• Patch author correct
• CHANGES.md appended
• README.md appended
• Credits appended
• Appropriate Comment quantity
• Successful Moodle PHPDoc check

version.php

• Checked if $plugin->version increment necessary (and increment done if necessary)
• $plugin->release untouched

lib.php

• Only necessary functions

Languages

• Only english strings
• Necessary magic strings added (e.g. capabilities)

Automated tests

• New functionality covered
• No failing steps or scenarios

Mustache templates

• Example context exists

CSS and styles.css

• Bootstrap styles used if possible

Duplicated code

• Duplicated code is marked properly

Github action

• All green

Commit history and scope

• Already single commit
• Focus on single purpose
• No surplus files

Additional aspects for Boost Union

• No usage of $theme->settings
• Usage of isset() checks when processing plugin settings in renderer / output code
• Usage of admin_setting_configselect instead of admin_setting_configcheckbox
• Modified mustache templates properly marked and .upstream template in place

Review result

• Tested again, works as aspected
• PR covers multiple issues, but in a valid scope